[core] fix PinExistingReturnObject segfault by passing owner_address #46973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When worker crash-restarts, there is a chance that it would call PinExistingReturnObject() to pin existing objects. But PinExistingReturnObject() calls GetThreadContext() which doesn't work for async actor methods. The owner_address is already there before calling PinExistingReturnObject(). This fix try to avoid the segfault by passing owner_address to PinExistingReturnObject(). Signed-off-by: hongchaodeng <[email protected]>
hongchaodeng
force-pushed
the
fix-threadlocal
branch
from
8c97b9d
to
86cd5e3
Compare
rynewang
approved these changes
Aug 6, 2024
Let me create another PR for it. I have a couple of ideas to refactor it. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When worker crash-restarts, there is a chance that it would call PinExistingReturnObject() to pin existing objects. But PinExistingReturnObject() calls GetThreadContext() which doesn't work for async actor methods.
The owner_address is already there before calling PinExistingReturnObject(). This fix try to avoid the segfault by passing owner_address to PinExistingReturnObject().
Related issue number
fix #46489
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.